Refactor: Enhance Spotify Optimistic UI Architecture - #9664
Conversation
- Moved duplicated context logic out of AudioContext to hooks/useAudioPreference.ts - Refactored SpotifyControls to fully utilize useSpotifyVolume, removing duplicated local state - Extracted scaling logic in VolumeSlider to leverage MUI theme.spacing instead of a manual scaleFactor - Removed stale constants and updated syncing locks - Updated spotifyPlayerManager executeOptimistic to emit failure events, unlocking useSpotifyVolume UI freeze early - Cleaned up redundant verbose comments in SpotifyControls Co-authored-by: arii <342438+arii@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Moved duplicated context logic out of AudioContext to hooks/useAudioPreference.ts - Refactored SpotifyControls to fully utilize useSpotifyVolume, removing duplicated local state - Extracted scaling logic in VolumeSlider to leverage MUI theme.spacing instead of a manual scaleFactor - Removed stale constants and updated syncing locks - Updated spotifyPlayerManager executeOptimistic to emit failure events, unlocking useSpotifyVolume UI freeze early - Cleaned up redundant verbose comments in SpotifyControls Co-authored-by: arii <342438+arii@users.noreply.github.com>
👋 Welcome to HRM!Thanks for your contribution. This repository uses Gemini AI for automated triage, code review, and generation. 🤖 Gemini Manual Trigger Quick Reference
For more details and GitHub CLI examples, see the Manual Trigger Guide. |
🤖 Gemini Review SkippedReview was skipped for the following reason: 🤖 Gemini Manual Trigger Guide |
arii
added
the
not reviewed
- Restored \`sendVolumeCommand\` inside \`SpotifyControls\` to avoid ReferenceError when calling \`useSpotifyVolume\`. - Cleaned up broken / duplicate tests and restored unit testing for \`SpotifyControls\` and \`SpotifyDisplay\` by correctly mocking \`useSpotifyCommand\` and \`useSpotifyVolume\`. - Added missing \`SPOTIFY_OPTIMISTIC_FAILURE\` ServerMessage type mapping. - Added \`onEvent\` explicitly to \`WebSocketContextType\` signature and exposed it in \`WebSocketProvider\`. - Addressed leftover \`any\` typings reported by strict \`knip\` & TS type checks. Co-authored-by: arii <342438+arii@users.noreply.github.com>
🤖 Gemini Review SkippedReview was skipped for the following reason: 🤖 Gemini Manual Trigger Guide |
arii
added
not reviewed
- Fix missing strict typings for the onEvent custom hook mapping. - Change `any` typings to `unknown` to satisfy strict ts checks. - Add optional chaining property accesses. - Run prettier and lint --fix to ensure codebase standards. Co-authored-by: arii <342438+arii@users.noreply.github.com>
🤖 Gemini Review SkippedReview was skipped for the following reason: 🤖 Gemini Manual Trigger Guide |
arii
added
not reviewed
- Removed `fix-lint.js`, `fix-tests.js`, and `fix-volume.js` from the repository root as they were causing Knip checks to fail by tracking unused files. Co-authored-by: arii <342438+arii@users.noreply.github.com>
🤖 Gemini Review SkippedReview was skipped for the following reason: 🤖 Gemini Manual Trigger Guide |
arii
added
not reviewed
0c65504
into
refactor/spotify-optimistic-ui-11189282566171114552
1 participant
This commit refines the previous PR's approach to the client-optimistic Spotify syncing architecture. It resolves the duplicate logic introduced in AudioContext.tsx by properly extracting the preferences hook into its own file. It also resolves a desync where optimistic UI failures would artificially lock the client for 2 seconds. The SpotifyPlayerManager now correctly emits a `SPOTIFY_OPTIMISTIC_FAILURE` event that `useSpotifyVolume` intercepts to instantly unlock the slider. Furthermore, redundant states and boilerplate throttle logic from `SpotifyControls` have been completely stripped out to rely solely on `useSpotifyVolume`. UI sizing logic in `VolumeSlider` is now natively using `theme.spacing()` instead of custom pixel multiplication values.
PR created automatically by Jules for task 18426785454480979537 started by @arii